Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typo in vault/secrets.tf for gitlab deployments #804

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

dan-os
Copy link
Contributor

@dan-os dan-os commented Sep 22, 2024

Description

I caught a small typo in the /deploy-tokens/container-registry-auth vault secret for all gitlab deployments. I discovered this while troubleshooting some authentication issues (although, this typo turned out to be unrelated to that). Thanks for all your work!

Related Issue(s)

N/A

How to test

N/A

Copy link
Member

@patrickdappollonio patrickdappollonio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for catching this!

@fharper fharper merged commit a2dfdb2 into konstructio:main Jan 6, 2025
@fharper
Copy link
Contributor

fharper commented Jan 6, 2025

@dan-os can you ping me on our Slack community, I'm Fred. I would like to send you some swag as a token of our appreciation for your contribution to Kubefirst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants